[jira] [Commented] (XALANJ-2346) [PATCH] fixes for faulty NaN handling

Discussion:

Dave Brosius (JIRA)

2016-05-20 11:00:17 UTC

[ https://issues.apache.org/jira/browse/XALANJ-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15293178#comment-15293178 ]

Dave Brosius commented on XALANJ-2346:
--------------------------------------

heh!

[PATCH] fixes for faulty NaN handling
-------------------------------------
Key: XALANJ-2346
URL: https://issues.apache.org/jira/browse/XALANJ-2346
Project: XalanJ2
Issue Type: Bug
Components: XSLTC
Affects Versions: 2.7.1
Reporter: Dave Brosius
Attachments: bad_nan.diff
By definition, NaN is not equal to itself, therefore
if (d == Double.NaN)
will always be false. Changed such instances to
if (Double.isNaN(d))

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@xalan.apache.org
For additional commands, e-mail: dev-***@xalan.apache.org

Gary Gregory (JIRA)

2016-05-21 21:17:13 UTC

Permalink

[ https://issues.apache.org/jira/browse/XALANJ-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Gregory updated XALANJ-2346:
---------------------------------
Summary: [PATCH] Fixes for faulty NaN handling (was: [PATCH] fixes for faulty NaN handling)

[PATCH] Fixes for faulty NaN handling
-------------------------------------
Key: XALANJ-2346
URL: https://issues.apache.org/jira/browse/XALANJ-2346
Project: XalanJ2
Issue Type: Bug
Components: XSLTC
Affects Versions: 2.7.1
Reporter: Dave Brosius
Attachments: bad_nan.diff
By definition, NaN is not equal to itself, therefore
if (d == Double.NaN)
will always be false. Changed such instances to
if (Double.isNaN(d))

Gary Gregory (JIRA)

2016-05-22 01:40:12 UTC

Permalink

[ https://issues.apache.org/jira/browse/XALANJ-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Gregory closed XALANJ-2346.
--------------------------------
Resolution: Fixed
Assignee: Gary Gregory
Fix Version/s: 2.7.3

{noformat}
commit -m "[XALANJ-2346][PATCH] Fixes for faulty NaN handling." -N E:/vcs/svn/apache/xalan-j/branches/xalan-j_2_7_1_maint/java/src/org/apache/xalan/lib/ExsltDatetime.java E:/vcs/svn/apache/xalan-j/branches/xalan-j_2_7_1_maint/java/src/org/apache/xalan/xsltc/compiler/Mode.java
Sending E:/vcs/svn/apache/xalan-j/branches/xalan-j_2_7_1_maint/java/src/org/apache/xalan/lib/ExsltDatetime.java
Sending E:/vcs/svn/apache/xalan-j/branches/xalan-j_2_7_1_maint/java/src/org/apache/xalan/xsltc/compiler/Mode.java
Transmitting file data ...
Committed revision 1744990
{noformat}

build smoketest OK
build smoketest.xsltc OK
build smoketest.dev OK

Post by Gary Gregory (JIRA)
[PATCH] Fixes for faulty NaN handling
-------------------------------------
Key: XALANJ-2346
URL: https://issues.apache.org/jira/browse/XALANJ-2346
Project: XalanJ2
Issue Type: Bug
Components: XSLTC
Affects Versions: 2.7.1
Reporter: Dave Brosius
Assignee: Gary Gregory
Fix For: 2.7.3
Attachments: bad_nan.diff
By definition, NaN is not equal to itself, therefore
if (d == Double.NaN)
will always be false. Changed such instances to
if (Double.isNaN(d))